Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Badge to the managed set #3607 #3627

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Add Badge to the managed set #3607 #3627

merged 1 commit into from
Sep 24, 2024

Conversation

darinpope
Copy link
Contributor

@darinpope darinpope commented Sep 24, 2024 •
edited by basil
Loading

Add Badge to managed set as requested by @basil in #3607

Testing done

  • LINE=weekly PLUGINS=badge TEST=InjectedTest bash local-test.sh
  • LINE=2.462.x PLUGINS=badge TEST=InjectedTest bash local-test.sh
  • LINE=2.452.x PLUGINS=badge TEST=InjectedTest bash local-test.sh
  • LINE=2.440.x PLUGINS=badge TEST=InjectedTest bash local-test.sh

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira

Fixes #3607

@darinpope darinpope marked this pull request as ready for review September 24, 2024 16:23
@darinpope darinpope requested a review from a team as a code owner September 24, 2024 16:23
@darinpope darinpope linked an issue Sep 24, 2024 that may be closed by this pull request
Add Badge to the managed set #3607
Closed
@MarkEWaite MarkEWaite added the full-test Test all LTS lines in this PR and do not halt upon first error. label Sep 24, 2024
@MarkEWaite
Copy link
Contributor

Thanks @darinpope ! I added the full-test label to the pull request and started a build on ci.jenkins.io to check that the tests all pass.

basil
basil approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil added the enhancement New feature or request label Sep 24, 2024
@basil basil enabled auto-merge (squash) September 24, 2024 18:18
@basil basil merged commit 33f5861 into jenkinsci:master Sep 24, 2024
777 checks passed
@darinpope darinpope deleted the add-badge-to-managed-list branch October 8, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request full-test Test all LTS lines in this PR and do not halt upon first error.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Badge to the managed set
3 participants
@darinpope @MarkEWaite @basil