Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Promoted Builds to the managed set #3502

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

MarkEWaite
Copy link
Contributor

Add promoted builds to managed set

Fixes #3171

Testing done

Confirmed that tha tests previously failing with promoted builds are now passing.

Plugin tests that were checked include:

  • config-file-provider
  • copyartifact
  • credentials
  • credentials-binding
  • job-dsl
  • junit
  • promoted-builds
  • workflow-cps

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite MarkEWaite requested a review from a team as a code owner August 27, 2024 21:10
@MarkEWaite MarkEWaite added enhancement New feature or request weekly-test full-test Test all LTS lines in this PR and do not halt upon first error. and removed weekly-test labels Aug 27, 2024
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hudson.plugins.promoted_builds.PromotedBuildRebuildParameterProviderTest#testRebuild is incompatible with jenkinsci/rebuild-plugin#155.

@MarkEWaite
Copy link
Contributor Author

hudson.plugins.promoted_builds.PromotedBuildRebuildParameterProviderTest#testRebuild is incompatible with jenkinsci/rebuild-plugin#155.

Thanks! I've submitted a pull request that proposes a fix by using a different technique in the test to start that build. Pull request is:

If that technique is acceptable, I can merge that pull request and then use that as the version in this pull request.

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil enabled auto-merge (squash) August 28, 2024 01:18
@basil basil changed the title Add promoted builds to managed set Add Promoted Builds to the managed set Aug 28, 2024
@basil basil merged commit 2769886 into jenkinsci:master Aug 28, 2024
741 checks passed
@MarkEWaite MarkEWaite deleted the add-promoted-builds branch August 28, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request full-test Test all LTS lines in this PR and do not halt upon first error.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Promoted Builds to the managed set
2 participants