Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commons-math3-api plugin #3480

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

jonesbusy
Copy link
Contributor

Add commons-math3-api plugin

Testing done

PLUGINS=commons-math3-api TEST=InjectedTest bash local-test.sh

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy jonesbusy requested a review from a team as a code owner August 21, 2024 14:53
@timja
Copy link
Member

timja commented Aug 21, 2024

FWIW this has been removed from junit, are there consumers that would benefit from this?

@jonesbusy
Copy link
Contributor Author

Found some of them with compile scope dependency https://github.com/search?q=org%3Ajenkinsci+%22commons-math3%22&type=code&p=2

Most need refresh but a few looks still active.

Not sure if it deserve bom to have version managed at least

@timja
Copy link
Member

timja commented Aug 21, 2024

2 or 3 look somewhat active, 1 of them currently uses bom.

I think we can do this, anyone else got another opinion?

@basil
Copy link
Member

basil commented Aug 21, 2024

I don't see a problem with this as long as weekly tests are passing, though as noted above there is not much of a need for this in the ecosystem at present.

@timja timja merged commit 131d4af into jenkinsci:master Aug 22, 2024
186 checks passed
@jonesbusy jonesbusy deleted the feature/add-commons-math3-api branch August 22, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants