Revert ssh-credentials 342.x #3404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enkinsci#3402)" Plugin loading fails in several BOM tests, including: * `LINE=2.440.x PLUGINS=git-server TEST=InjectedTest bash local-test.sh` https://ci.jenkins.io/job/Tools/job/bom/view/change-requests/job/PR-3374/10/testReport/ lists the other plugins with failures as: * workflow-basic-steps with 2.440.x * git with 2.440.x and 2.452.x * pipeline-model-definition with 2.452.x * docker-workflow with 2.440.x and 2.452.x * blueocean plugin with 2.440.x and 2.452.x This reverts commit 63a6418.
MarkEWaite
added a commit
to MarkEWaite/ssh-credentials-plugin
that referenced
this pull request
Jul 25, 2024
The plugin compatibility tester mistakenly uses the version of optional plugins that is provided by the pom of the tested plugin rather than using the version of plugin that is listed in the pom file of the plugin bill of materials. Because of that issue, the 2.426.x plugin bill of materials version needs to remain on an older version in order to not include an optional dependency on a newer version of the trilead API plugin. 3080.vfa_b_e4a_a_39b_44 is the version immediately before a trilean API plugin upgrade in the BOM. jenkinsci/bom#3404 has more details jenkinsci#211 includes some discussion as well.
6 tasks
MarkEWaite
added a commit
that referenced
this pull request
Jul 25, 2024
…3402)" (#3404) Plugin loading fails in several BOM tests, including: * `LINE=2.440.x PLUGINS=git-server TEST=InjectedTest bash local-test.sh` https://ci.jenkins.io/job/Tools/job/bom/view/change-requests/job/PR-3374/10/testReport/ lists the other plugins with failures as: * workflow-basic-steps with 2.440.x * git with 2.440.x and 2.452.x * pipeline-model-definition with 2.452.x * docker-workflow with 2.440.x and 2.452.x * blueocean plugin with 2.440.x and 2.452.x This reverts commit 63a6418.
olamy
pushed a commit
to jenkinsci/ssh-credentials-plugin
that referenced
this pull request
Jul 26, 2024
The plugin compatibility tester mistakenly uses the version of optional plugins that is provided by the pom of the tested plugin rather than using the version of plugin that is listed in the pom file of the plugin bill of materials. Because of that issue, the 2.426.x plugin bill of materials version needs to remain on an older version in order to not include an optional dependency on a newer version of the trilead API plugin. 3080.vfa_b_e4a_a_39b_44 is the version immediately before a trilean API plugin upgrade in the BOM. jenkinsci/bom#3404 has more details #211 includes some discussion as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert ssh-credentials 342.x
Plugin loading fails in several BOM tests, including:
LINE=2.440.x PLUGINS=git-server TEST=InjectedTest bash local-test.shThe test report lists the other plugins with failures as:
This reverts commit 63a6418.
Testing done
LINE=2.440.x PLUGINS=git-server TEST=InjectedTest bash local-test.shpasses with this changeSubmitter checklist