Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.249.x #301

Merged
merged 8 commits into from
Sep 18, 2020
Merged

2.249.x #301

merged 8 commits into from
Sep 18, 2020

Conversation

jglick
Copy link
Member

@jglick jglick commented Sep 1, 2020

No description provided.

failFast Outdated Show resolved Hide resolved
@jglick

This comment has been minimized.

@jglick jglick added the enhancement New feature or request label Sep 2, 2020
@jglick jglick requested a review from dwnusbaum September 2, 2020 15:07
@dwnusbaum

This comment has been minimized.

@jglick
Copy link
Member Author

jglick commented Sep 2, 2020

Hmm, now on plugins depending on pipeline-build-step—but not pipeline-build-step itself—I am getting

Failed to load: Pipeline: Build Step (2.13)
 - Update required: Pipeline: Supporting APIs (3.4) to be updated to 3.5 or higher

which does not make sense given

<workflow-support-plugin.version>3.5</workflow-support-plugin.version>
. Some sort of bug in PCT? This release introduced usage of the BOM and I wonder if PCT is failing to override a version somewhere.

Also getting

com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 403 Forbidden for http://localhost:37881/jenkins/
	at com.gargoylesoftware.htmlunit.WebClient.throwFailingHttpStatusCodeExceptionIfNecessary(WebClient.java:701)
	at com.gargoylesoftware.htmlunit.WebClient.loadDownloadedResponses(WebClient.java:2452)
	at com.gargoylesoftware.htmlunit.html.HtmlFormUtil.submit(HtmlFormUtil.java:82)
	at org.jvnet.hudson.test.JenkinsRule$WebClient.login(JenkinsRule.java:2390)
	at org.jvnet.hudson.test.JenkinsRule$WebClient.login(JenkinsRule.java:2257)
	at org.jvnet.hudson.test.JenkinsRule$WebClient.login(JenkinsRule.java:2402)
	at org.jenkinsci.plugins.workflow.support.steps.input.InputStepTest.runAndContinue(InputStepTest.java:357)
	at org.jenkinsci.plugins.workflow.support.steps.input.InputStepTest.test_submitters(InputStepTest.java:238)

which needs to be evaluated; not obviously related to anything in jenkinsci/pipeline-input-step-plugin@pipeline-input-step-2.11...pipeline-input-step-2.12.

@dwnusbaum
Copy link
Member

@jglick I have also seen "Failed to load: ... Update required: Pipeline: Supporting APIs (3.4) to be updated to 3.5 or higher" for PCT runs against the latest release of workflow-multibranch, which also just started using the BOM.

@jglick

This comment has been minimized.

@dwnusbaum

This comment has been minimized.

@jglick
Copy link
Member Author

jglick commented Sep 17, 2020

I think I tracked down the issue. When a plugin A (e.g., credentials-binding) has a BOM-managed dep on the tests JAR of another plugin B (e,g,. workflow-support), but does not explicitly mention B itself as being in the test classpath (because it already is, transitively from something else), all is fine normally—the BOM aligns the versions. The trouble comes when PCT edits a/pom.xml: it adds an explicit version to the dependency on B (with classifier) that it finds. Thus the test-scoped CP of A includes an older version of b.hpi alongside the newer version of b-tests.jar. This is not great, but usually harmless. The error comes when we run with jth.jenkins-war.path (as we do here) and there is another plugin C (e.g., pipeline-input-step) in the megawar which depends on the new version of B: this will not load against the older version of B that it actually got, and in InjectedTest, testPluginActive fails because C did not load (even though this was not part of the test CP of B and may have been totally irrelevant to B’s tests).

@timja
Copy link
Member

timja commented Sep 18, 2020

I think you’ll find a few of the ignored tests here are because of this issue

@jglick jglick marked this pull request as ready for review September 18, 2020 16:25
@jglick jglick requested a review from timja September 18, 2020 16:25
@jglick
Copy link
Member Author

jglick commented Sep 18, 2020

Timeout in SCMRetrieverTest.selfTestLibraries looks like an uncategorizable flake, maybe a problem with the build agent.

@jglick jglick merged commit b246b67 into jenkinsci:master Sep 18, 2020
@jglick jglick deleted the 2.249.x branch September 18, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants