Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add joda-time-api and json-api plugins to managed set #2732

Merged

Conversation

jonesbusy
Copy link
Contributor

Add joda-time-api and json-api plugins to managed set

Testing done

PLUGINS=json-api,joda-time-api TEST=InjectedTest bash local-test.sh

Would be nice to run full test and see if can be included in next bom release so that future consumer can be adapted without specifying version

Submitter checklist

@jonesbusy jonesbusy requested a review from a team as a code owner December 8, 2023 10:32
@jonesbusy jonesbusy marked this pull request as draft December 8, 2023 10:55
@jonesbusy
Copy link
Contributor Author

Wait also for jenkins-infra/repository-permissions-updater#3681 to be included and we should cover much more duplication/dependency issue

@MarkEWaite
Copy link
Contributor

MarkEWaite commented Dec 8, 2023

I've added the weekly-test label so that we can check for surprises in one configuration. Less expensive than a full test, especially since we'll run a full test tomorrow.

The weekly-test also has the benefit that it will check the other changes that have been merged, like:

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@basil basil added the enhancement New feature or request label Dec 8, 2023
@basil basil marked this pull request as ready for review December 8, 2023 15:18
@basil basil merged commit e404ac8 into jenkinsci:master Dec 8, 2023
167 checks passed
@jonesbusy jonesbusy deleted the featur/add-json-and-joda-time-api-plugin branch December 8, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request weekly-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants