Add gson-api plugin to bom

[jonesbusy]

Not sure about the order. Should we fist replace dependency by the api plugin or first include it to bom ?

Testing done

PLUGINS=gson-api bash local-test.sh 

Submitter checklist

Beta Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did
4. Link to relevant issues in GitHub or Jira
5. Link to relevant pull requests, esp. upstream and downstream changes
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

[timja]

either works

[MarkEWaite]

Thanks for the pull request @jonesbusy . I'm borrowing it to run a larger test as part of the Artifactory brownout . I've added the weekly-test label so that it will run a wider range of tests on the pull request while we're in the brownout period. Brownout will end in about 45 minutes

[MarkEWaite]

Thanks very much. Passed the larger test

[basil]

@jonesbusy Very nice! Thanks a lot for this contribution. If you're interested, it would be nice to get rid of GSON from these plugins:

./git-client/WEB-INF/lib/gson-2.10.1.jar
./google-compute-engine/WEB-INF/lib/gson-2.9.0.jar
./google-kubernetes-engine/WEB-INF/lib/gson-2.10.1.jar
./google-oauth-plugin/WEB-INF/lib/gson-2.9.1.jar
./google-storage-plugin/WEB-INF/lib/gson-2.10.1.jar
./trilead-api/WEB-INF/lib/gson-2.8.9.jar

If you aren't interested, then that is quite alright and I will file some Jira tickets against those individual plugins so that we can track the long-term effort to consolidate this library.

Thanks again.

[basil]

Unrelated to this PR, but another top offender is Joda Time, which has embedded itself in many places:

aws-java-sdk-minimal/WEB-INF/lib/joda-time-2.8.1.jar
dockerhub-notification/WEB-INF/lib/joda-time-2.10.14.jar
google-metadata-plugin/WEB-INF/lib/joda-time-2.12.5.jar
google-oauth-plugin/WEB-INF/lib/joda-time-2.12.5.jar
google-storage-plugin/WEB-INF/lib/joda-time-2.12.5.jar
handy-uri-templates-2-api/WEB-INF/lib/joda-time-2.10.2.jar
pipeline-model-api/WEB-INF/lib/joda-time-2.10.5.jar
saml/WEB-INF/lib/joda-time-2.11.0.jar

org.json:json would be nice to turn into a library, especially because old versions have a weird license:

configuration-as-code/WEB-INF/lib/json-20231013.jar
jackson2-api/WEB-INF/lib/json-20231013.jar

The pair of json-path/json-smart also crops up now and again:

google-kubernetes-engine/WEB-INF/lib/json-path-2.8.0.jar
google-kubernetes-engine/WEB-INF/lib/json-smart-2.4.10.jar
token-macro/WEB-INF/lib/json-path-2.8.0.jar
token-macro/WEB-INF/lib/json-smart-2.4.10.jar

[jonesbusy]

@basil Thanks, yea I will do the replacement step by step starting with existing API plugins in the bom. I started with the 'git-client' for now

I can take the point of org.json:json and joda-time it's ok for me.

[jonesbusy]

@basil Following PR have been open (some merged / releases already)

• Use api plugins google-kubernetes-engine-plugin#363
• Use json-path api plugin token-macro-plugin#204
• Use joda-time api plugin saml-plugin#389
• Use joda-time api plugin aws-java-sdk-plugin#1159
• Use joda-time api plugin handy-uri-templates-2-api-plugin#29
• Use joda-time api plugin pipeline-model-definition-plugin#684
• Use json-api plugin jackson2-api-plugin#228
• Use gson-api plugin trilead-api-plugin#131
• Use json-api plugin configuration-as-code-plugin#2431
• Use joda-time api plugin dockerhub-notification-plugin#45

[basil]

Very nice!

[basil]

I have filed the following tickets to track the updating of analysis-model-api and warnings-ng:

• https://issues.jenkins.io/browse/JENKINS-72493
• https://issues.jenkins.io/browse/JENKINS-72494
• https://issues.jenkins.io/browse/JENKINS-72495
• https://issues.jenkins.io/browse/JENKINS-72496
• https://issues.jenkins.io/browse/JENKINS-72497

[basil]

I have filed the following tickets to track the updating of google-compute-engine, google-oauth, and google-storage:

• https://issues.jenkins.io/browse/JENKINS-72857
• https://issues.jenkins.io/browse/JENKINS-72858
• https://issues.jenkins.io/browse/JENKINS-72859

I have filed the following tickets to track the updating of google-metadata, google-oauth, and google-storage:

• Implement dynamic linking with Joda Time API plugin google-metadata-plugin#65
• https://issues.jenkins.io/browse/JENKINS-72860
• https://issues.jenkins.io/browse/JENKINS-72861