Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add declarative Pipeline dependency to sample plugin #2478

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Add declarative Pipeline dependency to sample plugin #2478

merged 1 commit into from
Sep 7, 2023

Conversation

MarkEWaite
Copy link
Contributor

Add declarative Pipeline dependency to sample plugin

Plugin has a declarative Pipeline test in DeclarativePipelineTest.java

#2470 (comment) provides more reasoning why the dependency should be included.

This reverts part of commit acad2e3.

Testing done

Confirmed that mvn clean verify passes

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite
Add declarative Pipeline dependency to sample plugin
7d080c3 
Plugin has a declarative Pipeline test in DeclarativePipelineTest.java

jenkinsci#2470 (comment)
provides more reasoning why the dependency should be included.

This reverts part of commit acad2e3.
@MarkEWaite MarkEWaite requested a review from a team as a code owner September 7, 2023 15:27
@MarkEWaite MarkEWaite enabled auto-merge (squash) September 7, 2023 15:48
@MarkEWaite MarkEWaite merged commit 453a45b into jenkinsci:master Sep 7, 2023
@MarkEWaite MarkEWaite deleted the add-declarative-pipeline-to-sample branch September 11, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkEWaite @jglick