Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker-workflow plugin to the managed set #2464

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Add docker-workflow plugin to the managed set #2464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a936432
Add docker-workflow plugin to managed set
MarkEWaite Sep 4, 2023
c056d81
Merge branch 'master' into add-docker-workflow-plugin
basil Sep 5, 2023
ef59e02
Merge branch 'master' into add-docker-workflow-plugin
MarkEWaite Sep 5, 2023
f0bb487
Remove docker-commons from sample-plugin dependencies
MarkEWaite Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions bom-weekly/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,6 +511,11 @@
<artifactId>docker-java-api</artifactId>
<version>3.3.1-79.v20b_53427e041</version>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>docker-workflow</artifactId>
<version>572.v950f58993843</version>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>durable-task</artifactId>
Expand Down
4 changes: 2 additions & 2 deletions sample-plugin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,12 +421,12 @@
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>docker-commons</artifactId>
<artifactId>docker-java-api</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>docker-java-api</artifactId>
<artifactId>docker-workflow</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could then remove docker-commons.

Copy link
Contributor Author

@MarkEWaite MarkEWaite Sep 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have removed docker-commons and confirmed that sample plugin tests pass locally. That has been pushed as commit f0bb487

Since docker-workflow depends on several other plugins, should I remove those other dependencies from the sample plugin as well?

docker-workflow Dependencies

I was able to remove the following plugins from the sample-plugin pom file and still pass mvn verify:

Is it OK to remove those five dependencies from the sample plugin?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, you could.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. If this run fails, I'll add those changes to the next run. If it succeeds and merges, I'll submit them as a separate pull request.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2470 is the pull request that removes several transitive dependencies from the pom of the sample plugin.

<scope>test</scope>
</dependency>
<dependency>
Expand Down