Dropping 2.332.x & 2.346.x #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
added
the
full-test
jglick
commented
Jan 3, 2023
| @@ -7,9 +7,6 @@ updates: | |||
| - "jglick" | |||
| schedule: | |||
| interval: "daily" | |||
| ignore: | |||
| # TODO until 2.332.x & 2.346.x dropped | |||
There was a problem hiding this comment.
Was obsolete as of #1642 anyway.
| @@ -7,8 +7,7 @@ assert artifactMap['junit:junit'] == project.artifactMap['junit:junit'] | |||
| def managedPluginDeps = managedDeps.collect {stripAllButGA(it)}.grep { ga -> | |||
| def art = artifactMap[ga] | |||
| if (art == null) { | |||
| if (ga.contains('.plugins') // TODO without an Artifact, we have no reliable way of checking whether it is actually a plugin | |||
| && !(ga == 'io.jenkins.plugins:ionicons-api' && settings.activeProfiles.any {it ==~ /^2[.](332)[.]x$/})) { // TODO: Remove once 2.332.x is no longer part of the BOM (or if MNG-5600 is fixed and we can exclude this dependency in the BOM for old LTS lines) | |||
| if (ga.contains('.plugins')) { // TODO without an Artifact, we have no reliable way of checking whether it is actually a plugin | |||
timja
approved these changes
Jan 3, 2023
MarkEWaite
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1667 (comment) and in many other cases plugins will be 2.361.x+, so it is cumbersome to update them past that switch (jenkinsci/plugin-pom#478), and older BOM releases will become increasingly quiescent anyway. Will probably also unblock #1647 though I am not attempting that here.