-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pipeline-model-definition
and fix related test
#2555
Conversation
pipeline-model-definition
and fix related test
@@ -10,6 +12,7 @@ public class ExportConfig { | |||
* @deprecated | |||
* Use getter and setter | |||
*/ | |||
@SuppressFBWarnings(value="PA_PUBLIC_PRIMITIVE_ATTRIBUTE", justification="Preserve API compatibility") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required because the parent POM update picks up a new SpotBugs version. The justification is just copied over from https://github.com/jenkinsci/stapler/blob/35363c1920d2701aeefb05b57b07d721dfc48c5d/core/src/main/java/org/kohsuke/stapler/export/ExportConfig.java#L16. I do not know why we have a copy of half of that package here.
@@ -514,16 +516,26 @@ | |||
<artifactId>handy-uri-templates</artifactId> | |||
<version>2.1.8</version> | |||
</dependency> | |||
<!-- enforcer RequireUpperBoundDeps --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two old entries were actually causing upper bounds errors after the Jenkins and BOM updates.
@@ -37,7 +37,7 @@ | |||
<groupId>org.eclipse.jgit</groupId> | |||
<artifactId>org.eclipse.jgit.ssh.jsch</artifactId> | |||
<!-- TODO this is hard to manage; if needed, should be in BOM --> | |||
<version>6.6.1.202309021850-r</version> | |||
<version>6.9.0.202403050737-r</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to match the BOM updates.
@@ -122,6 +122,7 @@ public Object save(@NonNull String apiUrl, @Nullable String owner, @Nullable Str | |||
* | |||
* @return If new branch is created, sha of content.path on the new branch otherwise null | |||
*/ | |||
@SuppressFBWarnings(value = "NP_UNWRITTEN_FIELD", justification = "Fields populated reflectively when deserializing JSON to Java") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required because the parent POM update picks up a new SpotBugs version.
All tests passed besides |
@timja Maybe better to leave this in in draft state until the release is out. |
Description
see jenkinsci/pipeline-model-definition-plugin#700
(save resources not running against the full bom as its only this plugin it affects)
I've tried running this locally but I can't get the plugin to build due to old npm.
tried on both mac intel and arm.
Submitter checklist
Reviewer checklist