Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar fix to jenkinsci/jenkins#8776
See JENKINS-72467.
This ensures that the blueocean pages are displayed in the language requested by the browser, and not falling back to the default JVM locale when requesting english.
Verified manually that with this change, a JVM with
-Duser.language=fr
, and a browser configured for english only, the BlueOcean page is displayed in english only. When adding the french language to the browser, the page is then translated to french as expected (at least for the translated strings part of Blue Ocean).Could not add a unit test to verify the behaviour as I'm not familiar with how BlueOcean deals with resource bundles and there was no existing bundle part of
blueocean-i18n
that I could reuse to implement a test.Submitter checklist
Reviewer checklist