Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72467] Fix localization #2534

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

Vlatombe
Copy link
Member

Description

Similar fix to jenkinsci/jenkins#8776

See JENKINS-72467.

This ensures that the blueocean pages are displayed in the language requested by the browser, and not falling back to the default JVM locale when requesting english.

Verified manually that with this change, a JVM with -Duser.language=fr, and a browser configured for english only, the BlueOcean page is displayed in english only. When adding the french language to the browser, the page is then translated to french as expected (at least for the translated strings part of Blue Ocean).

Could not add a unit test to verify the behaviour as I'm not familiar with how BlueOcean deals with resource bundles and there was no existing bundle part of blueocean-i18n that I could reuse to implement a test.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

@Vlatombe Vlatombe requested a review from a team as a code owner December 14, 2023 09:16
@olamy olamy merged commit cf48ed7 into jenkinsci:master Dec 18, 2023
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants