Prevent multiBranchPipelineIndex failure due to DirectoryNotEmptyException #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test failed on a plugin bill of materials run for 2 of the 4 tested configurations. The failure message was a Caused by: java.nio.file.DirectoryNotEmptyException: blueocean-pipeline-api-impl/target/tmp/j h2197780848444070882/jobs/p This is a rather heavy-handed way to avoid the intermittent test failure, since it will stop running the test in all environments, all the time. The other tests in this class that use the runAllTests flag have used it since 2016. I didn't find any reference that indicated the tests are enabled by any operation in the repository itself. They might be executed on a CI system that defines the RUN_MULTIBRANCH_TESTS environment variable.
Avoid intermittent DirectoryNotEmptyException in the test by delaying exit until Jenkins is quiet.
jglick
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Similar to #2468. TBH it is not clear to me what tests like this are even doing to begin with. That you get a 200 response from some HTTP endpoint? But it does not seem to assert the contents of the response at all. Apparently this is a multibranch project, and perhaps after branch indexing completes there are some builds? Or just branch projects with no builds?
|
Both failures in https://github.com/jenkinsci/blueocean-plugin/pull/2505/checks?check_run_id=17030384497 look like unrelated flakes. |
MarkEWaite
added a commit
to jenkinsci/bom
that referenced
this pull request
Oct 21, 2023
Would be better to exclude only for Jenkins 2.387.x, since the test has been fixed in jenkinsci/blueocean-plugin#2505 , but there is not currently a way to exclude a test for a single line. Includes a TODO comment that the exclusion should be removed when the 2.387.x line is no longer included in the plugin bill of materials. https://github.com/jenkinsci/bom/pull/2593/checks?check_run_id=17920234324 shows the most recent failure only happeend on the 2.387.x line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix multiBranchPipelineIndex test failure
https://github.com/jenkinsci/bom/runs/16996428210 shows the failure happened in 2 of the 4 configurations that are tested by the plugin bill of materials.
This pull request resolves the issue by
We like having the blueocean plugin in the Jenkins plugin bill of materials so that we can detect issues more quickly.
Submitter checklist
Reviewer checklist