-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent multiBranchPipelineIndex failure due to DirectoryNotEmptyException #2505
Prevent multiBranchPipelineIndex failure due to DirectoryNotEmptyException #2505
Conversation
The test failed on a plugin bill of materials run for 2 of the 4 tested configurations. The failure message was a Caused by: java.nio.file.DirectoryNotEmptyException: blueocean-pipeline-api-impl/target/tmp/j h2197780848444070882/jobs/p This is a rather heavy-handed way to avoid the intermittent test failure, since it will stop running the test in all environments, all the time. The other tests in this class that use the runAllTests flag have used it since 2016. I didn't find any reference that indicated the tests are enabled by any operation in the repository itself. They might be executed on a CI system that defines the RUN_MULTIBRANCH_TESTS environment variable.
Avoid intermittent DirectoryNotEmptyException in the test by delaying exit until Jenkins is quiet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to #2468. TBH it is not clear to me what tests like this are even doing to begin with. That you get a 200 response from some HTTP endpoint? But it does not seem to assert the contents of the response at all. Apparently this is a multibranch project, and perhaps after branch indexing completes there are some builds? Or just branch projects with no builds?
Both failures in https://github.com/jenkinsci/blueocean-plugin/pull/2505/checks?check_run_id=17030384497 look like unrelated flakes. |
Would be better to exclude only for Jenkins 2.387.x, since the test has been fixed in jenkinsci/blueocean-plugin#2505 , but there is not currently a way to exclude a test for a single line. Includes a TODO comment that the exclusion should be removed when the 2.387.x line is no longer included in the plugin bill of materials. https://github.com/jenkinsci/bom/pull/2593/checks?check_run_id=17920234324 shows the most recent failure only happeend on the 2.387.x line.
Fix multiBranchPipelineIndex test failure
https://github.com/jenkinsci/bom/runs/16996428210 shows the failure happened in 2 of the 4 configurations that are tested by the plugin bill of materials.
This pull request resolves the issue by
We like having the blueocean plugin in the Jenkins plugin bill of materials so that we can detect issues more quickly.
Submitter checklist
Reviewer checklist