Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to latest LTS for node and npm #1922

Merged
merged 5 commits into from
Mar 5, 2019
Merged

Upgrade to latest LTS for node and npm #1922

merged 5 commits into from
Mar 5, 2019

Conversation

halkeye
Copy link
Member

@halkeye halkeye commented Feb 28, 2019

Description

Related to JENKINS-56316. It should be easier to compile in windows now.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

NicuPascu
NicuPascu requested changes Mar 4, 2019
View reviewed changes
Copy link
Collaborator

@NicuPascu NicuPascu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we keep having exact versions for dependencies?

@halkeye halkeye merged commit 09e3b2e into jenkinsci:master Mar 5, 2019
@halkeye halkeye deleted the improvement/JENKINS-56316 branch March 5, 2019 16:44
This was referenced Mar 31, 2019
Closed
Merged
@halkeye halkeye added enhancement skip-changelog Ignored by release-drafter (Usually CI or pipeline changes) labels Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicuPascu NicuPascu NicuPascu approved these changes

@d3rp3tt3 d3rp3tt3 Awaiting requested review from d3rp3tt3

@kzantow kzantow Awaiting requested review from kzantow

@olamy olamy Awaiting requested review from olamy

@scherler scherler Awaiting requested review from scherler

@vivek vivek Awaiting requested review from vivek

@imeredith imeredith Awaiting requested review from imeredith

@sophistifunk sophistifunk Awaiting requested review from sophistifunk

Assignees
No one assigned
Labels
enhancement skip-changelog Ignored by release-drafter (Usually CI or pipeline changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@halkeye @NicuPascu