Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade of gradle-jpi plugin, jenkins version and supporting libs #50

Merged
merged 3 commits into from
Dec 13, 2022

Conversation

jppetrakis
Copy link
Contributor

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Dependent upon: synopsys-sig/jenkins-common#34

As with pull request 33, changes made to build.gradle to address known security vulnerabilities exposed by earlier versions of jenkins-jpi, jenkins-core and other jenkins supporting plugins. The following versions are proposed:

jenkins-jpi v 0.43.0
jenkins-core 2.334 (matching in jenkins-common)

The jenkins jpi version requires an upgrade for gradle from 5.2 to 6.x (6.3 chosen).
This upgrade ALSO changes certain keywords used in the gradle file, most notably:

coreVersion -> jenkinsVersion
jenkinsPlugins -> implementation
testCompile -> testImplementaion
optionalJenkinsPlugins -> Corrected to reflect PROPER optional dependency. Behavior should be on par with original form.

build.gradle Show resolved Hide resolved
@jppetrakis jppetrakis merged commit f1bc6e2 into master Dec 13, 2022
@zbynek
Copy link

zbynek commented Feb 22, 2023

@jppetrakis I'm pretty sure this caused https://issues.jenkins.io/browse/JENKINS-70671, would you be able to check?

@jppetrakis
Copy link
Contributor Author

@zbynek The gradle-jpi plugin that we needed to use has changed considerably over the last two years, and this upgrade mainly consists of using newer versions of the same, original dependencies. I do not know why certain libraries such as jenkins-core are in the hpi file now whereas not before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants