-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project key to cache key #837
base: master
Are you sure you want to change the base?
Add project key to cache key #837
Conversation
src/main/java/com/cloudbees/jenkins/plugins/bitbucket/client/BitbucketCloudApiClient.java
Show resolved
Hide resolved
52aafe2
to
2f7a1a4
Compare
4481063
to
c51763a
Compare
c51763a
to
b9f51d0
Compare
@KalleOlaviNiemitalo @lifeofguenter does anything speak against merging this PR? I think this is a very useful bugfix, as caching without the project key causes issues. |
2ddc58a
to
a0491ee
Compare
@KalleOlaviNiemitalo any update on this? |
If a requests is sent with a project key, and the key is not part of the cache key, following requests for other projects will result in the cached repositories for the first project, leading to wrong results
a0491ee
to
220d2ca
Compare
i hope that at least one of the current maintainer will take action on this PR @dwnusbaum @bitwiseman @car-roll @lifeofguenter this is not a feature but a bug fix. Because cache feature was already in place. Using the BB project key in the organization folder configuration is ignore on project rescan causing on this folder to be populated with all repositories regardless in which project they are. |
If a requests is sent with a project key, and the key is not part of the cache key, following requests for other projects will result in the cached repositories for the first project, leading to wrong results
Your checklist for this pull request
Fixes #836