Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get fresh oauth token on every git clone #824

Merged

Conversation

andrey-fomin
Copy link
Contributor

@andrey-fomin andrey-fomin commented Mar 10, 2024

Previously token was fetched only once and saved in BitbucketSCMSource.

Fixes #808.
See also #810 and #796.

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates feature works or fixes the issue.

Previously token was fetched only once and saved in BitbucketSCMSource.

Fixes jenkinsci#808.
See also jenkinsci#810 and jenkinsci#796.
@lifeofguenter lifeofguenter added fix java Pull requests that update Java code labels Mar 10, 2024
@lifeofguenter
Copy link
Contributor

Awesome 🫶

@lifeofguenter lifeofguenter merged commit 4a79ab9 into jenkinsci:master Mar 10, 2024
16 checks passed
@ManneW
Copy link

ManneW commented Mar 12, 2024

Might this be a fix for #816 as well, @andrey-fomin?

That issue (#816) do seem to be related to authentication and some kind of expiration of credentials/tokens, since it seems to be working as expected when forcefully doing Bitbucket interactions at regular intervals, but not otherwise.

@andrey-fomin
Copy link
Contributor Author

@ManneW Looks like the #816 should also be fixed.

@giri-vsr please can you check?

@ManneW
Copy link

ManneW commented Mar 12, 2024

@andrey-fomin; Nice! 👏

FYI @giri-vsr: I'll install the updated version and will remove the "periodic fetching" setting for one of our projects and see if it keeps working 🤞 🙂

@0x01F4
Copy link

0x01F4 commented Mar 12, 2024

@andrey-fomin I have also removed "periodic fetching".I will confirm after a day.

@0x01F4
Copy link

0x01F4 commented Mar 18, 2024

@andrey-fomin working fine after this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication fails when using OAuth Credentials
4 participants