Remove mandatory install of blue ocean plugin #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotMyFault
added
the
breaking
timja
reviewed
Jan 3, 2024
NotMyFault
force-pushed
the
drop-bo-dependency
branch
from
220a87f to
ef7c398
Compare
Good idea, I didn't consider that :) |
NotMyFault
added
enhancement
and removed
breaking
timja
approved these changes
Jan 3, 2024
timja
changed the title
Rip, can we add a dummy constructor like: public AzureStorageBlueArtifact() {
super(null);
this.action = null;
this.artifact = null;
}or sth else? |
i think so |
|
I removed the Rest API for Blue Ocean plugin after seeing this update that it was no longer required for the Azure Storage plugin to work. After removing these plugins and restarting Jenkins, I noticed the following errors in our Jenkins system logs. As far as I can tell, everything still works as expected, but seeing these errors in the logs after restart was initially startling: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #278
As a user of the azure-storage plugin who doesn't use BO at all, it's frustrating that I need this dependency installed.
Would you strongly object to removing the BO integration all together @timja?
It was added in 2018 when BO was alive, but 6 years later, it's declared abandoned and EOL. I see no real reason why we should keep up an integration for an end-of-life plugin.