Fix BlockBlobClient cast error downloading from job #226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I make extensive use of "Download artifact from build -> Upstream build that triggered this job". As of today, this throws:
This doesn't work with the current mix of Azure plugin dependencies on an up-to-date Jenkins install. The core issue is when the download items are enumerated, they are of type
BlockBlobClient
notBlobClient
- theinstanceof
check therefore falls through into theShareFileClient
case, and that's not a valid cast.Instead, check for the parent type of both
BlobClient
andBlockBlobClient
,BlobClientBase
. This is valid for the current case and the old case, so should be safe for various combinations of dependency versions.