Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting of HTTP client timeouts with system properties #24

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

krische
Copy link
Contributor

@krische krische commented Jun 23, 2021

This pull request allows the timeouts of the HTTP client to be set using system properties. This closes #23

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@krische krische requested a review from a team as a code owner June 23, 2021 13:59
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this would be handled automatically, possibly raising a support ticket or raising an upstream issue to the SDK would be good to get more info.

But this is enough as a workaround

@timja timja added the enhancement New feature or request label Jun 23, 2021
@timja timja merged commit 5682688 into jenkinsci:master Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting of HTTP client timeouts
2 participants