Many jobs based on the same agent template produce many failed deployment #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sparsick
commented
Feb 14, 2022
sparsick
commented
- add workaround for unexpected NullPointerException
- improve logging
- tested manually in Azure with container, that use Private IP Addresses and Public IP Addresses
- fixes Many jobs based on the same agent template produce many failed deployment #101
- Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
- Ensure that the pull request title represents the desired changelog entry
- Please describe what you did
- Link to relevant issues in GitHub or Jira
- Link to relevant pull requests, esp. upstream and downstream changes
- Ensure you have provided tests - that demonstrates feature works or fixes the issue
- improve logging
timja
reviewed
Feb 14, 2022
| boolean nullIsThrown; | ||
| do { | ||
| try { | ||
| ip = azureResourceManager.containerGroups() |
There was a problem hiding this comment.
could we check the ip address for null instead and then retry rather than handling a null pointer?
is it possible the IP hasn't been allocated yet? seems quite weird though
There was a problem hiding this comment.
the NullPointerException is coming from Resource Manager internally
There was a problem hiding this comment.
java.lang.NullPointerException
at com.azure.resourcemanager.containerinstance.implementation.ContainerGroupImpl.initializeChildrenFromInner(ContainerGroupImpl.java:217)
timja
reviewed
Feb 14, 2022
src/main/java/com/microsoft/jenkins/containeragents/aci/AciCloud.java
Outdated
Show resolved
Hide resolved
timja
reviewed
Feb 14, 2022
| azureResourceManager.containerGroups().getByResourceGroup(resourceGroup, agent.getNodeName()); | ||
|
|
||
| if (containerGroup.containers().containsKey(agent.getNodeName()) | ||
| && containerGroup.containers().get(agent.getNodeName()).instanceView().currentState().state() |
There was a problem hiding this comment.
could we check the container for null instead and then retry rather than handling a null pointer?
There was a problem hiding this comment.
the NullPointerException is coming from Resource Manager internally
Co-authored-by: Tim Jacomb <[email protected]>
|
Have you tested this and it solves the issue? |
|
Yes, I tested it with both kind of container instances (private and public ip addresses) and it works like I expected. Logoutput for private IP Container usage: Job output: |
|
@timja I will open a new issue to remove this workaround when issue Azure/azure-sdk-for-java#27083 is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.