Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for all uploads to complete #128

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

pregress
Copy link
Contributor

@pregress pregress commented Dec 9, 2024

This change introduces a fix for #48 by using a CountDownLatch to wait until all files are uploaded.

Fixes #48

Testing done

Ran the existing integration tests.
Tested with: https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/plugins/azure-artifact-manager/181.v233fd271dd66/azure-artifact-manager-181.v233fd271dd66.hpi

image

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@pregress
Copy link
Contributor Author

pregress commented Dec 9, 2024

@strangelookingnerd or @gavinfish could you have a look? And if possible merge and release this?

Disclaimer: I'm not a Java dev, and noticed there is no coverage, also not for the existing code: #17 (comment)

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timja timja added the bug Something isn't working label Dec 9, 2024
@timja timja changed the title #48 use CountDownLatch to wait for all uploads to complete Wait for all uploads to complete Dec 9, 2024
@timja timja merged commit cce8710 into jenkinsci:master Dec 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipeline file builds not being blocked
2 participants