Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP use ServiceLoader to load credential factories #298

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

chriskilding
Copy link
Contributor

@chriskilding chriskilding commented Sep 5, 2023

This PR enables the dynamic discovery of credential type factories via the Java ServiceLoader.

It lays the groundwork for the Secrets Manager Credentials Provider to support custom credential types (such as GitHub or BrowserStack credentials). This will be achieved by creating downstream plugins for each of these credential types; each downstream plugin will contain an AwsCredentialsFactory implementation.

As a useful side benefit, breaking the credential type factories out into their own plugins should also make the test suites for each one simpler and quicker.

Testing done

Submitter checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant