WIP use ServiceLoader to load credential factories #298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the dynamic discovery of credential type factories via the Java
ServiceLoader
.It lays the groundwork for the Secrets Manager Credentials Provider to support custom credential types (such as GitHub or BrowserStack credentials). This will be achieved by creating downstream plugins for each of these credential types; each downstream plugin will contain an
AwsCredentialsFactory
implementation.As a useful side benefit, breaking the credential type factories out into their own plugins should also make the test suites for each one simpler and quicker.
Testing done
Submitter checklist