Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt tests to upstream KeyStore validation #170

Merged
merged 1 commit into from
Jul 8, 2024
Merged

adapt tests to upstream KeyStore validation #170

merged 1 commit into from
Jul 8, 2024

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Jul 8, 2024 •
edited
Loading

Adapt to jenkinsci/credentials-plugin#543 by using a valid but empty PKCS12 keystore

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jtnord jtnord requested a review from a team as a code owner July 8, 2024 16:35
@jglick jglick merged commit 5028514 into jenkinsci:master Jul 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

Assignees
No one assigned
Labels
developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtnord @jglick