Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude parent pom 5.x from renovate updates #763

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Oct 7, 2024

Exclude parent pom 5.x from renovate updates

Projects configured from the archetype most often prefer to depend on the last release of a recent LTS line. The archetype currently requires Jenkins 2.440.3 or newer. When we switch to parent pom 5.x, we'll need to require Jenkins 2.475 (weekly) or Jenkins 2.479.x (LTS).

I think it will be several months before we're ready to switch the archetype to use plugin parent pom 5.x. Until that time, this configures renovate to only recommend versions less than 5.x

Testing done

Installed and ran the renovate-config-validator locally with commands:

$ nvm install --lts
$ npx --yes --package renovate -- renovate-config-validator

Before this change, reported that migration was needed. After this change, it no longer reports that migration is needed.

Does not check that the package name is correct, though I checked that with git grep.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Projects configured from the archetype most often prefer to depend on
the last release of a recent LTS line.  The archetype currently requires
Jenkins 2.440.3 or newer.  When we switch to parent pom 5.x, we'll need
to require Jenkins 2.475 (weekly) or Jenkins 2.479.x (LTS).

I think it will be several months before we're ready to switch the
archetype to use plugin parent pom 5.x.  Until that time, this configures
renovate to only recommend versions less than 5.x
Installed the renovate-config-validator locally with commands:

$ nvm install --lts
$ npx --yes --package renovate -- renovate-config-validator

Ran the configuration validator with

$ renovate-config-validator

Before this change, reported that migration was needed.  After this
change, it no longer reports that migration is needed.
@timja timja merged commit 76f97e8 into jenkinsci:master Oct 7, 2024
2 checks passed
@MarkEWaite MarkEWaite deleted the exclude-parent-pom-5 branch October 7, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants