Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renovate syntax error, migrate to recommended configuration #64

Merged

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Oct 23, 2024

Fix renovate syntax error, migrate to recommended configuration

The presets-config documentation describes the "config:recommended" usage. The migration message from the configuration validator includes that setting in the message.

Does not adopt the upgrade best practices recommended in upgrade best practices documentation. If that is desired, I'm happy to make that change as well.

Fixes #63

Testing done

Tested with:

$ renovate-config-validator
 INFO: Validating .github/renovate.json
 INFO: Config validated successfully

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

https://docs.renovatebot.com/presets-config/ describes the
"config:recommended" usage.

Does not adopt the upgrade best practices recommended in
https://docs.renovatebot.com/upgrade-best-practices/ .  If that is
desired, I'm happy to make that change as well.

Tested with:

$ renovate-config-validator
 INFO: Validating .github/renovate.json
 INFO: Config validated successfully
@MarkEWaite MarkEWaite requested a review from a team as a code owner October 23, 2024 11:10
@strangelookingnerd strangelookingnerd merged commit 88f403c into jenkinsci:main Oct 23, 2024
17 checks passed
@MarkEWaite MarkEWaite deleted the fix-renovate-syntax-error branch October 23, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action Required: Fix Renovate Configuration
2 participants