Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PMD logo location in SUPPORTED-FORMATS.md #975

Merged
merged 3 commits into from
Nov 19, 2023

Conversation

StefanSpieker
Copy link
Contributor

Update PMD logo location in SUPPORTED-FORMATS.md

Testing done

Only markdown related changes, checking if logo is again displayed:
grafik

Submitter checklist

@KalleOlaviNiemitalo
Copy link

Would it be better to have a commit ID in the URL instead of "master"? If PMD ever renames the "master" branch then I don't know whether the raw.githubusercontent.com link will keep working.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7f7f0c) 93.07% compared to head (c2625d4) 93.07%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #975   +/-   ##
=========================================
  Coverage     93.07%   93.07%           
  Complexity     2371     2371           
=========================================
  Files           347      347           
  Lines          6588     6588           
  Branches        686      686           
=========================================
  Hits           6132     6132           
  Misses          256      256           
  Partials        200      200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner added the documentation Enhancement of documentation label Nov 14, 2023
Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the logo. Can you please make the change in PmdDescriptor? The Markdown file is generated from all descriptors and will be overwritten the next time someone adds a new parser.

And for me it is ok to use a link to master as this helps to keep the logo up to date if the PMD team changes it. (It does not help if they decide to switch to main branch.)

@StefanSpieker
Copy link
Contributor Author

Thanks, I wasn't aware that it is generated - simply overlooked the header. I generated the file again to be sure that it is fine now.

@uhafner uhafner merged commit 543f754 into jenkinsci:main Nov 19, 2023
27 checks passed
@StefanSpieker StefanSpieker deleted the StefanSpieker-patch-1 branch November 19, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Enhancement of documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants