Added support for multiple servers without assigned ports #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
code LGTM - but the history would be a little unclear due to the merge in the ancestry. Can you rebase the change ontop of origin/master? |
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
nieuwtje
force-pushed
the
multiple-domain-add-ports-if-missing
branch
from
6eafcf8
to
a1ab420
Compare
nieuwtje
force-pushed
the
multiple-domain-add-ports-if-missing
branch
from
a1ab420
to
da41bf6
Compare
|
@fbelzunc FYI. |
jtnord
added a commit
that referenced
this pull request
Mar 3, 2016
…sing Added support for multiple servers without assigned ports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever multiple domain controllers are defined, but they don't have a port assigned, only the last domain controller was given a port -> Added support for multiple servers without assigned ports.