Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TestNotSerrialzibleCPS and related files #543

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

nre-ableton
Copy link
Contributor

This test never worked properly because it expected any Exception to be
thrown, and in fact, this test throws:

groovy.lang.MissingMethodException: No signature of method:
com.lesfurets.jenkins.TestNotSerrialzibleCPS.containsString() is
applicable for argument types: (java.lang.String) values: [Unable to
serialize locals]

This can be fixed by statically importing containsString, but when that
is done, the test passes because there is no Serializable exception
thrown by the test case.

Overall, I think that this test isn't contributing much to the framework
and it should instead be removed.

Fixes #522

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

This test never worked properly because it expected any Exception to be
thrown, and in fact, this test throws:

groovy.lang.MissingMethodException: No signature of method:
com.lesfurets.jenkins.TestNotSerrialzibleCPS.containsString() is
applicable for argument types: (java.lang.String) values: [Unable to
serialize locals]

This can be fixed by statically importing containsString, but when that
is done, the test passes because there is no Serializable exception
thrown by the test case.

Overall, I think that this test isn't contributing much to the framework
and it should instead be removed.
@nre-ableton nre-ableton merged commit 65d5d96 into master Jul 11, 2022
@nre-ableton nre-ableton deleted the nre/master/522-serialization-test-failure branch July 11, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant