Don't use a single type in MockScriptHandler constructor
#541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation of the MockScriptHandler constructor was a bit brittle and confusing. The first parameter was an Object which could either be null (for no pattern matching), a String (for full pattern matching), or a Pattern (for a regexp pattern match). This change now provides three different constructors for the three different use-cases detailed above, and also creates separate fields for the various matches. This means we no longer need to rely on instanceof to see what type of filter should be applied.
|
@lemeurherve I've invited you as a reviewer, in case you are interested in seeing this change. |
|
Sorry I missed that one, thanks a lot @nre-ableton |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of trying to squeeze three values in one
Objecttype, this change introduces more constructor overrides for theMockScriptHandlerclass.Note that this will be an API-breaking change that we'll need to document when released.
Fixes #536.