Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DockerMock): calls should show up in the call stack #535

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

stanovchar
Copy link

@stanovchar stanovchar commented Jun 2, 2022

Refactored Docker Mock tests. Setup Interceptors to trace docker mock methods in the call stack.

Fixes #406

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@stchar
Copy link
Contributor

stchar commented Jun 2, 2022

Oh grep, just noticed that I had used another account to open the PR.

@nre-ableton
Copy link
Contributor

nre-ableton commented Jun 2, 2022

BTW, I'm ok with this PR, but of course it'll need to be reworked to drop c1dd159 and remove the multiple arguments in some of the tests. Just ping me when you've pushed and I'll have another look.

@stchar stchar force-pushed the feature/docker-mock-callstack branch from b6d1603 to a6ec8a9 Compare June 2, 2022 11:28
@stchar
Copy link
Contributor

stchar commented Jun 2, 2022

Rebased. No more dependency on #534

@stchar stchar force-pushed the feature/docker-mock-callstack branch from a6ec8a9 to ddce01a Compare June 2, 2022 11:32
Copy link
Contributor

@nre-ableton nre-ableton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, please disregard my previous review, I submitted it just seconds before you force-pushed. 😄 Anyways, LGTM, assuming that the tests pass.

@nre-ableton nre-ableton merged commit cdad22c into master Jun 2, 2022
@nre-ableton nre-ableton deleted the feature/docker-mock-callstack branch June 2, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DockerMock calls don't show up in the call stack
3 participants