fix error when using empty agent label #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update AgentDeclaration to only fail if label is null (and not found via other conditionals) instead of when it is falsy. Fixes #412
pkwarren
commented
Oct 27, 2021
| @@ -647,4 +647,12 @@ class TestDeclarativePipeline extends DeclarativePipelineTest { | |||
| assertCallStack().contains('echo(Deploy to someLabel)') | |||
| assertJobStatusSuccess() | |||
| } | |||
|
|
|||
| @Test void should_agent_with_empty_label() throws Exception { | |||
There was a problem hiding this comment.
This test failed prior to making the suggested code change.
nre-ableton
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update AgentDeclaration to only fail if label is null (and not found via
other conditionals) instead of when it is falsy.
Fixes #412