Add fileExists mock with helper methods #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
stchar
requested changes
Oct 17, 2020
This mock is similar to the readFile mock in that mock files can be added to the PipelineTestHelper. If no filename is registered with the helper, then the mock returns false by default.
nre-ableton
force-pushed
the
nre/master/add-fileexists-mock
branch
from
e7b939d
to
4279125
Compare
|
re-ping @stchar -- are you ok with the PR now that documentation has been updated? |
stchar
approved these changes
Oct 29, 2020
timja
reviewed
Mar 9, 2021
| @@ -206,6 +206,7 @@ node { | |||
| ```groovy | |||
| @Test | |||
| void exampleReadFileTest() { | |||
| helper.addFileExistsMock('fileExists', true) | |||
There was a problem hiding this comment.
shouldn't this be
helper.addFileExistsMock('output', true)?
There was a problem hiding this comment.
Ah yeah, I think this is a typo. See #350.
This was referenced Mar 15, 2021
Merged
| @@ -1,5 +1,7 @@ | |||
| package com.lesfurets.jenkins.unit | |||
|
|
|||
| import com.sun.org.apache.xpath.internal.operations.Bool | |||
There was a problem hiding this comment.
Hello @nre-ableton !
Why this unused import com.sun.org.apache.xpath.internal.operations.Bool here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a solution to the problems discussed in #306, by allowing users
to register filenames with a desired result for the mock.