Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for nesting stages including parallel #297

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

Willem1987
Copy link
Contributor

Added test to validate #238

@nre-ableton
Copy link
Contributor

Can you please be a bit more descriptive in the PR issue and commit messages? The issue number is not interesting as far as this goes; please tell what problem is being solved. Thanks!

@Willem1987
Copy link
Contributor Author

Basically this is just a unit test, to attempt to reproduce (does not seem to occur). And make sure the functionality does not break again. I am unsure what to state.

@nre-ableton
Copy link
Contributor

How about "Add unit test for parallel nested stages"?

@Willem1987
Copy link
Contributor Author

Commit message updated

Copy link
Contributor

@nre-ableton nre-ableton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit 039cb58 still has a very unclear commit message, as does this pull request title. Can you please fix these?

I guess 039cb58 might be redundant once you rebase this branch, though.

@Willem1987 Willem1987 changed the title Issue 238 Add test for nesting stages including parallel Oct 10, 2020
@Willem1987
Copy link
Contributor Author

Rebased and renamed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants