Handle default return correctly when returnStatus is used #267
Conversation
The original default behavior for the `sh` step was undefined and fell through the inaccurate handling of the resturnStdout behavior. This will result in a success returnStatus when requested instead of a string return.
src/main/groovy/com/lesfurets/jenkins/unit/PipelineTestHelper.groovy
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
First, thanks for the PR. 👍 I didn't account for this particular case, because the codepath of the original code that this feature was ported from would raise an exception if no mock output was registered. That was removed in order to avoid a breaking change when merging that PR.
This PR looks fine except for the empty return statement, which I left a line comment about.
src/main/groovy/com/lesfurets/jenkins/unit/PipelineTestHelper.groovy
Outdated
Show resolved
Hide resolved
…groovy Make correction to final return for clarity and to avoid unnecessary return trigger from IntelliJ Co-authored-by: Nik Reiman <[email protected]>
|
For what it is worth, the original code also returns a multiline string as output when returnStdout=false which failed to pass when returnStatus=true because of the missing condition. Additionally, the default behavior of returnStdout=false and returnStatus=false is not implemented accurately in this block of code as it will still fall through to the multiline string return. |
The original default behavior for the
shstep was undefined and fellthrough the inaccurate handling of the resturnStdout behavior. This will
result in a success returnStatus when requested instead of a string
return.