Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 249: Eliminate use of @Memoized #262

Merged
merged 2 commits into from
Aug 22, 2020

Conversation

Alex-Vol-SV
Copy link
Contributor

Created a direct callable method clearCallStack() and removed the use of @Memoized to avoid problems with resetting the call stack between runs. The output is cached like it was with `@Memoized to avoid unnecessary overhead from repeated calls to assert call stack states.

Fixed two minor compilation issues that were found in Eclipse IDE. The code changes are minor but if there are objections to the changes I can remove the commit from the pull request.

Two issues with the code that were fixable to allow the
execution/compilation inside the IDE.
…havior

Enabled the clearing of the call stack to generate a fresh copy of the
call stack but retained the Memoized efficiency. This can be cleared
either with the reinitialization using setUp() or with the new direct
callable clearCallStack() method.
Copy link
Contributor

@stchar stchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BasePipelineTest: Memoized result from callStackDump
2 participants