Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #260: Fix IllegalArgumentException with GlobalVar taking a single argument #261

Merged
merged 2 commits into from
Aug 13, 2020
Merged

Issue #260: Fix IllegalArgumentException with GlobalVar taking a single argument #261

merged 2 commits into from
Aug 13, 2020

Commits on Aug 12, 2020

  1. Fix IllegalArgumentException with Global Var taking a single argument 

    When calling a Gloval Var declared to accept one argument and the caller
passes null to the function it yields an IllegalArgumentException
instead of passing the null argument. This is unique to single argument
method calls and appears rooted in the way Groovy lang handles the
invocation when null is provided.

This fix was inspired from the code in the invoked Groovy methods.
    @Alex-Vol-SV
    Alex-Vol-SV committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    58b1bf9 View commit details
    Browse the repository at this point in the history

  2. Update src/test/resources/libs/commons@feature/vars/oneArg.groovy 

    Taking one line improvement

Co-authored-by: Nik Reiman <[email protected]>
    @Alex-Vol-SV @nre-ableton
    Alex-Vol-SV and nre-ableton authored Aug 12, 2020
    Configuration menu
    Copy the full SHA
    24e61da View commit details
    Browse the repository at this point in the history