Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue where agent closure with a label referencing a param variable causes test failures #252

Merged
merged 2 commits into from
Jul 23, 2020
Merged

fix issue where agent closure with a label referencing a param variable causes test failures #252

merged 2 commits into from
Jul 23, 2020

Conversation

ballab1
Copy link
Contributor

@ballab1 ballab1 commented Jul 18, 2020

Issue #239: Unable to use "${param.SOMEVAR}" in an agent label

@ballab1 ballab1 mentioned this pull request Jul 18, 2020
Closed
@ballab1
Copy link
Contributor Author

ballab1 commented Jul 19, 2020

realized there was a condition where the values of mocked parameters would get overwritten by content in the Jenkinsfile.
Fixed class so that if a param is defined it ill not be overwritten.This allows params to be mocked (before a test),and the mocked value to persist for the test

@ballab1 ballab1 changed the title fix issue where agent closure with a label referencing a param variable cuases test failures fix issue where agent closure with a label referencing a param variable causes test failures Jul 20, 2020
stchar
stchar approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@stchar stchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

This was linked to issues Jul 23, 2020
Environment Variables Not Recognized in Agent section #180
Closed
Bug: Unable to use "${param.SOMEVAR}" in an agent label #239
Closed
@stchar stchar merged commit 8330c41 into jenkinsci:master Jul 23, 2020
@stchar stchar linked an issue Jul 23, 2020 that may be closed by this pull request
Provide a mechanism to stub agent methods in declarative pipelines #208
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stchar stchar stchar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ballab1 @stchar