Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle failures in sh step with returnStdout #329

Merged
merged 2 commits into from
Jan 28, 2021

Conversation

nre-ableton
Copy link
Contributor

Fixes #327

Even if returnStdout is true, Jenkins will raise an exception if the
script fails.
@nre-ableton nre-ableton force-pushed the nre/master/returnStdout-failure branch from bae5aa9 to e883520 Compare January 4, 2021 12:26
This matches Jenkins' own behavior.
Copy link
Contributor

@stchar stchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runSh bails out too early when requested to finish with error code.
3 participants