Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runSh bails out too early when requested to finish with error code. #327

Closed
apogrebnyak opened this issue Dec 29, 2020 · 1 comment · Fixed by #329
Closed

runSh bails out too early when requested to finish with error code. #327

apogrebnyak opened this issue Dec 29, 2020 · 1 comment · Fixed by #329

Comments

@apogrebnyak
Copy link

Real sh step when run with returnStdout:true argument, will still finish with error when script inside sh returns non-0 status.

However, because of this logic

JenkinsPipelineUnit/src/main/groovy/com/lesfurets/jenkins/unit/PipelineTestHelper.groovy

Line 691 in a469daf

return stdout

the mocked version of sh bails out too early, and no exception is thrown upon error exit status.
@nre-ableton nre-ableton mentioned this issue Jan 4, 2021
Merged
@nre-ableton
Copy link
Contributor

Yes, you're right, this seems to be the correct behavior. Please see #329.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle failures in sh step with returnStdout nre-ableton/JenkinsPipelineUnit
2 participants
@apogrebnyak @nre-ableton