Exchange adopt with temurin in CD example
#66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotMyFault
changed the title
adopt with temurinadopt with temurin in CD example
NotMyFault
commented
Jan 24, 2022
| with: | ||
| distribution: 'adopt' | ||
| distribution: temurin | ||
| java-version: 8 |
There was a problem hiding this comment.
Wondering if it would be worth to run the release task with 11 instead 8 🤔
There was a problem hiding this comment.
unsure, definitely should when plugins are allowed to be java 11 only
There was a problem hiding this comment.
That for sure, should be non-breaking though, considering it's the Java version the runner uses, not the Java version the plugin is compiled against or sth.
timja
approved these changes
Jan 24, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AdoptOpenJDK has moved to the Eclipse Foundation and does now deploy their OpenJDK builds under Adoptium.
If you use
adoptin your runner files, you get Java 8.0.292+1, the last build under AdoptOpenJDK, where Temurin serves 8.0.312+7, the actual latest build of Java 8.A minor change but, but ensures your runner uses an up to date version of Java.