Update setup-java to v2 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
approved these changes
Apr 6, 2021
this is an implementation detail |
jglick
reviewed
Apr 6, 2021
| with: | ||
| distribution: 'adopt' | ||
| java-version: 1.8 |
There was a problem hiding this comment.
Acc. to @garethjevans this also needs to be switched to 8 (or distribution be set to the original zulu)?
There was a problem hiding this comment.
There was a problem hiding this comment.
#50, apparently the only place I tested it in CI was using jdk 11 🤦
jglick
added a commit
to jenkinsci/jenkins-test-harness
that referenced
this pull request
Apr 7, 2021
jglick
added a commit
to jenkinsci/file-parameters-plugin
that referenced
this pull request
Apr 13, 2021
This was referenced Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jenkinsci/azure-artifact-manager-plugin#14
See https://github.com/actions/setup-java/blob/main/docs/adrs/0000-v2-setup-java.md
Note: this has a breaking change in it, distribution is now required, and worse our repoes only using github actions for CD don't test the action on CI
@jenkinsci/github-admins