-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new function to run cwp without exiting a process #640
Conversation
Codecov Report
@@ Coverage Diff @@
## master #640 +/- ##
=======================================
Coverage 37.98% 37.98%
=======================================
Files 13 13
Lines 416 416
=======================================
Hits 158 158
Misses 246 246
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
I want to use the cwpOptions.Run() method in other go files, but this function uses syscall.Exec() which ends a process and the following code are not executing. So I creates a new function called RunWithoutProcessExits() and the logic is the same basically, while using exec.Command() which doesn't exiting a process instead of syscall.Exec(). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. There are a few small problems you might need to take a look at them.
The e2e Test/ Build ubuntu failed, but I don't know why. Could someone give me a hint on it. That would be appreciated. |
Hello Rick! This pr is needed to be merged first. Thanks for your reviewing.
But this is not a complete file and more information about cobra is available here. |
Make sure that you've checked the boxes below before you submit PR:
Always
For the bug fixes or features only