Add support conduct an API test of plugins #624

jxr98 · 2021-08-29T03:48:59Z

Make sure that you've checked the boxes below before you submit PR:

Always

Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
Written well with PR title, we generate the release notes base on that

For the bug fixes or features only

codecov · 2021-08-29T03:49:42Z

Codecov Report

Merging #624 (7458f8a) into master (0a0e878) will not change coverage.
The diff coverage is n/a.

❗ Current head 7458f8a differs from pull request most recent head 51775e6. Consider uploading reports for the commit 51775e6 to get more accurate results

@@           Coverage Diff           @@
##           master     #624   +/-   ##
=======================================
  Coverage   37.98%   37.98%           
=======================================
  Files          13       13           
  Lines         416      416           
=======================================
  Hits          158      158           
  Misses        246      246           
  Partials       12       12

Flag	Coverage Δ
unittests	`37.98% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dc48d8...51775e6. Read the comment docs.

LinuxSuRen · 2021-08-30T08:03:05Z

go.mod

 	golang.org/x/text v0.3.6
+	golang.org/x/tools v0.1.5 // indirect


Do we really need these go modules? I didn't find any import statements.

I had run 'go mod tidy' and the go.mod did include golang.org/x/tools. And it was required by another dependency.

LinuxSuRen · 2021-08-30T08:03:33Z

app/cmd/docker_plugin_apitest.go

+	Short:   "",
+	Long:    "",


Why empty here?

LinuxSuRen · 2021-08-30T08:04:39Z

app/cmd/docker_plugin_apitest.go

+var ip string
+var port string
+var jenkinsPluginTest jenkinsFormula.CustomWarPackage
+var pluginsWithProblem []string
+var userName string
+var token string


I prefer do not to expose all these variables. You can put some of them into https://github.com/jenkins-zh/jenkins-cli/pull/624/files#diff-02fba72fba6090f3f60ca286fe093f7744d9fe54dd4a1f006b60b1873c0a5bfaR39

ddd update center_list

JohnNiang · 2021-09-10T07:04:39Z

app/cmd/plugin_apitest.go

+			},
+		}
+		getCurrentJenkinsAndClient(&(jClient.JenkinsCore))
+		jClient.JenkinsCore.URL = fmt.Sprintf("http://%s:%s", pluginAPITestO.ip, pluginAPITestO.port)


What if the scheme of Jenkins URL is https?

I don't understand why we need to overwrite the URL here. Becuase I found that the method GetCurrentJenkinsAndClient will set it.

Because this function is to conduct an API test for plugins in upgraded jenkins which is different with the one clarified in .jenkins-cli.yaml.

JohnNiang · 2021-09-10T08:44:38Z

app/cmd/plugin_apitest.go

+				RoundTripper: pluginFormulaOption.RoundTripper,
+			},
+		}
+		getCurrentJenkinsAndClient(&(jClient.JenkinsCore))


Please note that the getCurrentJenkinsAndClient is deprecated. Use GetCurrentJenkinsAndClient instead.

JohnNiang · 2021-09-10T08:55:09Z

app/cmd/plugin_apitest.go

+			},
+		}
+		getCurrentJenkinsAndClient(&(jClient.JenkinsCore))
+		jClient.JenkinsCore.URL = fmt.Sprintf("http://%s:%s", pluginAPITestO.ip, pluginAPITestO.port)


I don't understand why we need to overwrite the URL here. Becuase I found that the method GetCurrentJenkinsAndClient will set it.

JohnNiang · 2021-09-10T09:00:26Z

app/cmd/plugin_apitest.go

+						if statusCode != 200 {
+							errorAPI, ok := pluginsWithProblemMap[plugin.ArtifactID]
+							if ok {
+								pluginsWithProblemMap[plugin.ArtifactID] = errorAPI + "   " + api


Why we keep three spaces here.

JohnNiang · 2021-09-10T09:05:52Z

app/cmd/plugin_apitest.go

+				for _, plugin := range apiTestO.Plugins {
+					apis := plugin.API
+					for _, api := range apis {
+						statusCode, _, err := jClient.JenkinsCore.Request(http.MethodGet, api, nil, nil)


jClient.JenkinsCore.Request -> jClient.Request

JohnNiang · 2021-09-10T09:13:38Z

app/cmd/plugin_apitest.go

+				if err != nil {
+					return err
+				}
+				pluginsWithProblemMap := make(map[string]string)


I suggest using map type: map[string][]string here.

* Fix computer launch for windows * Update create temporary directory * Remove some code

jxr98 · 2021-09-28T02:35:48Z

Sorry, I included some commits that are not mine. Will fix that in a short time.

jxr98 · 2021-09-28T03:35:28Z

The custom yaml need to follow the format of the following example:
plugins:

artifactId: "nameOne"
api :
- "/pluginManager/plugin/sshd/api/json"
- "/urlTwo"
artifactId: "nameTwo"
api :
- "/urlOne"

LinuxSuRen requested changes Aug 30, 2021

View reviewed changes

jxr98 changed the title ~~Add support conduct an API test of plugins~~ WIP:Add support conduct an API test of plugins Sep 8, 2021

jxr98 force-pushed the test branch from ece89ad to b591e86 Compare September 10, 2021 04:14

jxr98 added 2 commits September 10, 2021 12:25

ddd

fa075f1

ddd update center_list

add support to conduct api test for plugins

913f321

jxr98 force-pushed the test branch from 538433e to 913f321 Compare September 10, 2021 04:29

fix some lint mistakes and update go.sum

acc31a6

jxr98 changed the title ~~WIP:Add support conduct an API test of plugins~~ Add support conduct an API test of plugins Sep 10, 2021

JohnNiang reviewed Sep 10, 2021

View reviewed changes

jxr98 changed the title ~~Add support conduct an API test of plugins~~ WIP: Add support conduct an API test of plugins Sep 26, 2021

yJunS and others added 3 commits September 28, 2021 10:31

Fix computer launch for windows (jenkins-zh#635)

6e0789b

* Fix computer launch for windows * Update create temporary directory * Remove some code

Run release drafter in the GitHub action (jenkins-zh#636)

86562fd

modify plugin_apitest.go

09490aa

jxr98 added 6 commits September 28, 2021 11:09

resolve the conflict

3fc1c1b

do some changes to pluginsWithProblemMap

8ca1180

revert last 6 changes that include some commits from others

f5a22a5

do some changes to pluginsWithProblemMap

799526d

modify go.mod and go.sum

3703dd6

modify go.sum

7458f8a

jxr98 changed the title ~~WIP: Add support conduct an API test of plugins~~ Add support conduct an API test of plugins Sep 28, 2021

Merge branch 'master' into test

51775e6

LinuxSuRen approved these changes Jun 15, 2022

View reviewed changes

LinuxSuRen merged commit 26b4f1f into jenkins-zh:master Jun 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support conduct an API test of plugins #624

Add support conduct an API test of plugins #624

jxr98 commented Aug 29, 2021

codecov bot commented Aug 29, 2021 •

edited

Loading

LinuxSuRen Aug 30, 2021

jxr98 Aug 31, 2021

LinuxSuRen Aug 30, 2021

LinuxSuRen Aug 30, 2021

JohnNiang Sep 10, 2021

JohnNiang Sep 10, 2021

jxr98 Sep 10, 2021

JohnNiang Sep 10, 2021

JohnNiang Sep 10, 2021

JohnNiang Sep 10, 2021

JohnNiang Sep 10, 2021

JohnNiang Sep 10, 2021

jxr98 commented Sep 28, 2021

jxr98 commented Sep 28, 2021

		golang.org/x/text v0.3.6
		golang.org/x/tools v0.1.5 // indirect

Add support conduct an API test of plugins #624

Add support conduct an API test of plugins #624

Conversation

jxr98 commented Aug 29, 2021

Always

For the bug fixes or features only

codecov bot commented Aug 29, 2021 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jxr98 commented Sep 28, 2021

jxr98 commented Sep 28, 2021

codecov bot commented Aug 29, 2021 •

edited

Loading