Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade go and dependencies #1

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix: upgrade go and dependencies #1

wants to merge 8 commits into from

Conversation

msvticket
Copy link
Contributor

needed remove vault test to problems importing github.com/hashicorp/vault/vault

rewrote azure support since the old modules are deprecated

@msvticket
fix: upgrade go and dependencies
cc2b94a 
needed remove vault test to problems importing github.com/hashicorp/vault/vault

rewrote azure support since the old modules are deprecated
@msvticket
fix: update lint configuration
c72d664
@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign msvticket
You can assign the PR to them by writing /assign @msvticket in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msvticket
Copy link
Contributor Author

/retest

1 similar comment
@msvticket
Copy link
Contributor Author

/retest

@msvticket
Copy link
Contributor Author

/retest

1 similar comment
@msvticket
Copy link
Contributor Author

/retest

@msvticket
Copy link
Contributor Author

/retest

@msvticket
Copy link
Contributor Author

/retest

@msvticket
Copy link
Contributor Author

I upgraded all the dependencies of secretfacade and it turned out that the azure modules that where used where deprecated. So I tried to upgrade and had to do some code changes. Maybe you can review and when merged test the jx-secret PR for the upgrade of secretfacade on azure.

/cc @Skisocks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skisocks Skisocks Awaiting requested review from Skisocks

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msvticket @jenkins-x-bot