-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(publish) abstract environment variables and introduce feature flags #784
Merged
dduportal
merged 4 commits into
jenkins-infra:chore/publish/abstract-env
from
dduportal:chore/publish/abstract-env
May 31, 2024
Merged
chore(publish) abstract environment variables and introduce feature flags #784
dduportal
merged 4 commits into
jenkins-infra:chore/publish/abstract-env
from
dduportal:chore/publish/abstract-env
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lags Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
smerle33
reviewed
May 29, 2024
Co-authored-by: Stéphane MERLE <[email protected]>
dduportal
added a commit
to jenkins-infra/azure
that referenced
this pull request
May 30, 2024
Related to jenkins-infra/helpdesk#2649 and blocking jenkins-infra/update-center2#784 and jenkins-infra/charts-secrets#30 This PR simplifies and rename outputs to ensure the script used to generate the Update Center credential ZIP file in jenkins-infra/charts-secrets#30 can extract the proper output with the naming convention from jenkins-infra/update-center2#777 and jenkins-infra/update-center2#784 (`www-content` and `www-redirections`). - It avoids multiple levels of escaping challenges (current output requires 3 levels of escaping: in HCL syntax AND in shell syntax for the initial call AND on shell syntax in the file template itself) - The only "coupling" in Terraform HCL is the output name which is an acceptable contract: it avoid having to change things in the terraform state when only renaming a variable - No more risk to have a local env file committed by error and exposing the secrets --------- Signed-off-by: Damien Duportal <[email protected]>
We're merging this PR into a specific branch to allow testing. We'll open a subsequent PR for the final review to master branch. Any code review should happen in #787 |
dduportal
merged commit May 31, 2024
bfb7db4
into
jenkins-infra:chore/publish/abstract-env
0 of 2 checks passed
This was referenced May 31, 2024
Merged
dduportal
added a commit
that referenced
this pull request
Jun 4, 2024
…lags (#784) * chore(publish) abstract environment variables and introduce feature flags Signed-off-by: Damien Duportal <[email protected]> * comments fixup Signed-off-by: Damien Duportal <[email protected]> * Update site/publish.sh Co-authored-by: Stéphane MERLE <[email protected]> * enhance rsync ssh and rename pkg sync-task --------- Signed-off-by: Damien Duportal <[email protected]> Co-authored-by: Stéphane MERLE <[email protected]>
dduportal
added a commit
that referenced
this pull request
Jul 8, 2024
…lag (#787) * chore(publish) abstract environment variables and introduce feature flags (#784) * chore(publish) abstract environment variables and introduce feature flags Signed-off-by: Damien Duportal <[email protected]> * comments fixup Signed-off-by: Damien Duportal <[email protected]> * Update site/publish.sh Co-authored-by: Stéphane MERLE <[email protected]> * enhance rsync ssh and rename pkg sync-task --------- Signed-off-by: Damien Duportal <[email protected]> Co-authored-by: Stéphane MERLE <[email protected]> * Update site/publish.sh * Apply suggestions from code review Co-authored-by: Tim Jacomb <[email protected]> --------- Signed-off-by: Damien Duportal <[email protected]> Co-authored-by: Stéphane MERLE <[email protected]> Co-authored-by: Tim Jacomb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #777 for the Update Center migration to a mirror system, we realized the following problems with the current
publish.sh
script:This PR is a proposal to solve these issues with:
Example of the expected source file structures to be set in a ZIP credential file:
Note: This PR is ready to review but not to merge as the env. files need to be generated and set up AND no test done (yet) on real life