Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt extended-read-perms #3323

Merged
merged 1 commit into from
May 22, 2023

Conversation

NotMyFault
Copy link
Member

Looking forward to modernizing the plugin and delivering jenkinsci/extended-read-permission-plugin#18

cc @batmat @oleg-nenashev

Description

Submitter checklist for adding or changing permissions

Always

  • Add link to plugin/component Git repository in description above

When enabling automated releases (cd: true)

  • Add a link to the pull request, which enables continuous delivery for your plugin or component.
    Follow the documentation to ensure, your pull request is set up properly.

When adding new uploaders (this includes newly created permissions files)

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@NotMyFault NotMyFault requested a review from a team as a code owner May 22, 2023 12:09
Copy link
Contributor

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@oleg-nenashev oleg-nenashev merged commit 2ade570 into jenkins-infra:master May 22, 2023
@NotMyFault NotMyFault deleted the extended-read branch May 22, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants