Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basil to symbol-annotation #2197

Merged
merged 1 commit into from
Nov 20, 2021
Merged

Conversation

basil
Copy link
Contributor

@basil basil commented Nov 20, 2021

Description

See jenkinsci/jenkins#5293 (comment) for context. Please let me know if there is anything I can clarify.

Also updating the GitHub URL to reflect the pending split (see HOSTING-1155).

Repositories:

Submitter checklist for adding or changing permissions

Always

  • Add link to plugin/component Git repository in description above

For a newly hosted plugin only

  • Add link to resolved HOSTING issue in description above

For a new permissions file only

When adding new uploaders (this includes newly created permissions files)

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @daniel-beck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@basil basil requested a review from a team as a code owner November 20, 2021 20:01
@timja timja merged commit ed03b66 into jenkins-infra:master Nov 20, 2021
@basil basil deleted the symbol-annotation branch November 20, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants