Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure to remove maven.compiler.release when upgrading to 5.X of parent pom #293

Conversation

jonesbusy
Copy link
Collaborator

Amend #289

Property is present on the parent pom. So ensure it's not overriden

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy jonesbusy requested a review from a team as a code owner October 4, 2024 10:20
@jonesbusy jonesbusy merged commit 24fa46b into jenkins-infra:main Oct 4, 2024
15 checks passed
@jonesbusy jonesbusy deleted the feature/ensure-to-remove-compiler-property branch October 4, 2024 10:33
@jonesbusy
Copy link
Collaborator Author

I will most likely perform more test on draft PR but I prefer to wait jenkins-infra/jenkins-security-scan#32 to be merged and release. Or I we will have all the securty scan action failing

@jonesbusy jonesbusy added the chore label Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants