-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gitpod): Install SDKMAN in GitHub runners and GitPod, and keep JDK versions up-to-date #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
…6a5fcc2b9095e453695eeef973e032c0eb40a3a631e18823 [plugins] Update the versions of the temurin installers from SDKMAN
We shall correct it later on.
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
…7e105364b66594210ee2659045cfa3722f247066d212cf35 [plugins] Update the versions of the temurin installers from SDKMAN
Looks update cli failed. Excep that looks good on my side |
It is supposed to fail, as it is trying to update a file that doesn't exist yet. |
jonesbusy
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In issues and discussions #119 and #120, we discussed the possibility of compiling plugins before and after applying recipes. The main challenge is installing and switching between various JDK versions during this process.
Solution
This PR implements the following features:
JDK Installation:
Version Management:
Configuration:
plugin-modernizer-cli/src/main/resources/sdkman.properties
) listing JDK versions and their installation paths.Potential Usage
The Maven Invoker Library might allow us to launch a new Maven clean environment while specifying the JDK version (possibly through JAVA_HOME).
Limitations
While this setup may not be sufficient to automatically switch between installed JDKs during recipe application, it should assist developers in manually switching when migrating plugins between JDK versions (e.g., from JDK 6 to 11, or 11 to 17).
Next Steps
Feedback and suggestions for improvement are welcome.
Submitter checklist